]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
scsi: sd: Suppress spurious errors when WRITE SAME is being disabled
authorEwan D. Milne <emilne@redhat.com>
Mon, 7 Dec 2020 22:10:21 +0000 (17:10 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 27 Jan 2021 10:47:43 +0000 (11:47 +0100)
commit5a1d7bb7d333849eb7d3ab5ebfbf9805b2cd46c9
tree14741ed416f45a68573fc4a17d8c225d16bd078d
parent68f99105752d132d411231bfc60cf78eceaac5e0
scsi: sd: Suppress spurious errors when WRITE SAME is being disabled

[ Upstream commit e5cc9002caafacbaa8dab878d17a313192c3b03b ]

The block layer code will split a large zeroout request into multiple bios
and if WRITE SAME is disabled because the storage device reports that it
does not support it (or support the length used), we can get an error
message from the block layer despite the setting of RQF_QUIET on the first
request.  This is because more than one request may have already been
submitted.

Fix this by setting RQF_QUIET when BLK_STS_TARGET is returned to fail the
request early, we don't need to log a message because we did not actually
submit the command to the device, and the block layer code will handle the
error by submitting individual write bios.

Link: https://lore.kernel.org/r/20201207221021.28243-1-emilne@redhat.com
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ewan D. Milne <emilne@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/sd.c