]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
selftests/seccomp: Don't call read() on TTY from background pgrp
authorJann Horn <jannh@google.com>
Sat, 19 Mar 2022 01:00:11 +0000 (02:00 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 May 2022 10:25:39 +0000 (12:25 +0200)
commit5bf2a45e33438d18ff7153a635ec5fc3577f79da
tree81b3bd1c6a5cdf049461165796b321d23670ab42
parent3ea0b44c01ee4c180293707b741fbd4671a92634
selftests/seccomp: Don't call read() on TTY from background pgrp

commit 2bfed7d2ffa5d86c462d3e2067f2832eaf8c04c7 upstream.

Since commit 92d25637a3a4 ("kselftest: signal all child processes"), tests
are executed in background process groups. This means that trying to read
from stdin now throws SIGTTIN when stdin is a TTY, which breaks some
seccomp selftests that try to use read(0, NULL, 0) as a dummy syscall.

The simplest way to fix that is probably to just use -1 instead of 0 as
the dummy read()'s FD.

Fixes: 92d25637a3a4 ("kselftest: signal all child processes")
Signed-off-by: Jann Horn <jannh@google.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20220319010011.1374622-1-jannh@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
tools/testing/selftests/seccomp/seccomp_bpf.c