]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
thunderbolt: Fix property read in nhi_wake_supported()
authorKonrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Mon, 9 Mar 2026 09:39:49 +0000 (10:39 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 11 Apr 2026 12:29:56 +0000 (14:29 +0200)
commit5cba3060ee50ba2adeb63f4bfc098551839754a7
treebaa2102b5089e0d18ebe12e6a60ae25dc05a9e05
parent0b7845c6a3910544afbacee16949fe671724a4b3
thunderbolt: Fix property read in nhi_wake_supported()

commit 73a505dc48144ec72e25874e2b2a72487b02d3bc upstream.

device_property_read_foo() returns 0 on success and only then modifies
'val'. Currently, val is left uninitialized if the aforementioned
function returns non-zero, making nhi_wake_supported() return true
almost always (random != 0) if the property is not present in device
firmware.

Invert the check to make it make sense.

Fixes: 3cdb9446a117 ("thunderbolt: Add support for Intel Ice Lake")
Cc: stable@vger.kernel.org
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/thunderbolt/nhi.c