]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
appletalk: Fix skb allocation size in loopback case
authorDoug Brown <doug@schmorgal.com>
Fri, 12 Feb 2021 05:27:54 +0000 (21:27 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 7 Apr 2021 10:04:21 +0000 (12:04 +0200)
commit5d44e600c4be92b5651be022e4cd30cd5af7a1e1
tree212f2c3ee74d460fe3d66fe3fe0b35fc24ffdde5
parent2fc8ce56985de3b9e547748658772af30b915088
appletalk: Fix skb allocation size in loopback case

[ Upstream commit 39935dccb21c60f9bbf1bb72d22ab6fd14ae7705 ]

If a DDP broadcast packet is sent out to a non-gateway target, it is
also looped back. There is a potential for the loopback device to have a
longer hardware header length than the original target route's device,
which can result in the skb not being created with enough room for the
loopback device's hardware header. This patch fixes the issue by
determining that a loopback will be necessary prior to allocating the
skb, and if so, ensuring the skb has enough room.

This was discovered while testing a new driver that creates a LocalTalk
network interface (LTALK_HLEN = 1). It caused an skb_under_panic.

Signed-off-by: Doug Brown <doug@schmorgal.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/appletalk/ddp.c