]> git.ipfire.org Git - thirdparty/postgresql.git/commit
REPACK: do not require REPLICATION or LOGIN
authorÁlvaro Herrera <alvherre@kurilemu.de>
Mon, 20 Apr 2026 13:44:23 +0000 (15:44 +0200)
committerÁlvaro Herrera <alvherre@kurilemu.de>
Mon, 20 Apr 2026 13:44:23 +0000 (15:44 +0200)
commit5dbb63fc82b72ccc6f9e7be0361efdeee5deeb50
tree9771b08dc9b078ec2e21b86ca5434fbb9869e5d2
parent158d8fadd79f90935cb9bc1ae0bec366cbf09f42
REPACK: do not require REPLICATION or LOGIN

Although REPACK (CONCURRENTLY) uses replication slots, there is no
concern that the slot will leak data of other users, because the
MAINTAIN privilege on the table is required anyway; requiring
REPLICATION is user-unfriendly without providing any actual protection.

A related aspect is that the REPLICATION attribute is not needed to
prevent REPACK from stealing slots from logical replication, since
commit e76d8c749c31 made REPACK use a separate pool of replication
slots.

Similarly, there's no reason to require that the table owner has the
LOGIN privilege.  Bypass the default behavior in the background worker
launch sequence.

Because there are now successful concurrent repack runs in the
regression tests, we're forced to run test_plan_advice under
wal_level=replica, so add that.  Also, move the cluster.sql test to a
different parallel group in parallel_schedule: apparently the use of the
repack worker causes it to exceed the maximum limit of processes in some
runs (the actual limit reached is the number of XIDs in a snapshot's xip
array).

Author: Antonin Houska <ah@cybertec.at>
Reported-by: Justin Pryzby <pryzby@telsasoft.com>
Reviewed-by: Chao Li <lic@highgo.com>
Discussion: https://postgr.es/m/aeJHPNmL4vVy3oPw@pryzbyj2023
src/backend/commands/repack_worker.c
src/test/modules/test_plan_advice/t/001_replan_regress.pl
src/test/regress/expected/cluster.out
src/test/regress/parallel_schedule
src/test/regress/sql/cluster.sql