]> git.ipfire.org Git - thirdparty/linux.git/commit
udp: gso: Fix handling checksum in __udp_gso_segment
authorAlice Mikityanska <alice@isovalent.com>
Mon, 18 May 2026 06:22:49 +0000 (09:22 +0300)
committerJakub Kicinski <kuba@kernel.org>
Wed, 20 May 2026 22:02:47 +0000 (15:02 -0700)
commit5f17ae0f595aeb560155ce98edbe44d3eacc7e40
tree249c8bfa486a49febabc3a44aa114e08fcae3af1
parentdc416e32baaeb620b9809e9e25fc7b30889686e9
udp: gso: Fix handling checksum in __udp_gso_segment

The cited commit started using msslen for uh->len, but still uses newlen
to adjust uh->check. Although the checksum is ignored in most cases due
to the hardware offload, __udp_gso_segment attempts to maintain the
correct one. Fix uh->check and adjust it by the right value.

Additionally, after the fix, newlen becomes assigned and unused before
the loop. The code can be simplified a bit if mss adjustment is dropped,
so that newlen becomes equal to msslen before the loop, and msslen can
be also dropped, saving a few lines of code.

This brings us back to one variable, drops an unneeded arithmetic for
mss, and fixes the UDP checksum.

Fixes: b10b446ce7ad ("udp: gso: Use single MSS length in UDP header for GSO_PARTIAL")
Signed-off-by: Alice Mikityanska <alice@isovalent.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
Link: https://patch.msgid.link/20260518062250.3019914-2-gal@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv4/udp_offload.c