]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
irqchip/riscv-aplic: Do not clear ACPI dependencies on probe failure
authorJessica Liu <liu.xuemei1@zte.com.cn>
Tue, 10 Mar 2026 06:16:00 +0000 (14:16 +0800)
committerThomas Gleixner <tglx@kernel.org>
Tue, 10 Mar 2026 17:42:33 +0000 (18:42 +0100)
commit620b6ded72a7f0f77be6ec44d0462bb85729ab7a
treedd4b7727b019f5a41e484c1b2fbd3aaffd6e6116
parent1f318b96cc84d7c2ab792fcc0bfd42a7ca890681
irqchip/riscv-aplic: Do not clear ACPI dependencies on probe failure

aplic_probe() calls acpi_dev_clear_dependencies() unconditionally at the
end, even when the preceding setup (MSI or direct mode) has failed. This is
incorrect because if the device failed to probe, it should not be
considered as active and should not clear dependencies for other devices
waiting on it.

Fix this by returning immediately when the setup fails, skipping the ACPI
dependency cleanup. Also, explicitly return 0 on success instead of relying
on the value of 'rc' to make the success path clear.

Fixes: 5122e380c23b ("irqchip/riscv-aplic: Add ACPI support")
Signed-off-by: Jessica Liu <liu.xuemei1@zte.com.cn>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/20260310141600411Fu8H8-GXOOgKISU48Tjgx@zte.com.cn
drivers/irqchip/irq-riscv-aplic-main.c