]> git.ipfire.org Git - thirdparty/bind9.git/commit
Use memory_order_acq_rel in isc_refcount_decrement.
authorMark Andrews <marka@isc.org>
Tue, 25 Aug 2020 12:42:27 +0000 (22:42 +1000)
committerMark Andrews <marka@isc.org>
Tue, 1 Sep 2020 12:05:18 +0000 (12:05 +0000)
commit6278899a3849b7ee46b6460dff93e555e77d99a2
treedb5000f8878922bb0d1340c0e83e6d0377daea1b
parentfcd6962e8b60f54567a57db07fab3998ebcc946f
Use memory_order_acq_rel in isc_refcount_decrement.

While

if (isc_refcount_decrement() == 1) { // memory_order_release
isc_refcount_destroy(); // memory_order_acquire
...
}

is theoretically the most efficent in practice, using
memory_order_acq_rel produces the same code on x86_64 and doesn't
trigger tsan data races (which use a idealistic model) if
isc_refcount_destroy() is not called immediately.  In fact
isc_refcount_destroy() could be removed if we didn't want
to check for the count being 0 when isc_refcount_destroy() is
called.

https://stackoverflow.com/questions/49112732/memory-order-in-shared-pointer-destructor
lib/isc/include/isc/atomic.h
lib/isc/include/isc/refcount.h