]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
mpls: add seqcount to protect the platform_label{,s} pair
authorSabrina Dubroca <sd@queasysnail.net>
Mon, 23 Mar 2026 23:25:57 +0000 (00:25 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 27 Mar 2026 01:32:14 +0000 (18:32 -0700)
commit629ec78ef8608d955ce217880cdc3e1873af3a15
treefafc0f4c05bbd7c1d5ca9823cd30df856511be63
parent45dbf8fcea4dcf28cabcf4a1778e908feadf4c90
mpls: add seqcount to protect the platform_label{,s} pair

The RCU-protected codepaths (mpls_forward, mpls_dump_routes) can have
an inconsistent view of platform_labels vs platform_label in case of a
concurrent resize (resize_platform_label_table, under
platform_mutex). This can lead to OOB accesses.

This patch adds a seqcount, so that we get a consistent snapshot.

Note that mpls_label_ok is also susceptible to this, so the check
against RTA_DST in rtm_to_route_config, done outside platform_mutex,
is not sufficient. This value gets passed to mpls_label_ok once more
in both mpls_route_add and mpls_route_del, so there is no issue, but
that additional check must not be removed.

Reported-by: Yuan Tan <tanyuan98@outlook.com>
Reported-by: Yifan Wu <yifanwucs@gmail.com>
Reported-by: Juefei Pu <tomapufckgml@gmail.com>
Reported-by: Xin Liu <bird@lzu.edu.cn>
Fixes: 7720c01f3f590 ("mpls: Add a sysctl to control the size of the mpls label table")
Fixes: dde1b38e873c ("mpls: Convert mpls_dump_routes() to RCU.")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Link: https://patch.msgid.link/cd8fca15e3eb7e212b094064cd83652e20fd9d31.1774284088.git.sd@queasysnail.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/net/netns/mpls.h
net/mpls/af_mpls.c