]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
arm64: spinlocks: implement smp_mb__before_spinlock() as smp_mb()
authorWill Deacon <will.deacon@arm.com>
Mon, 5 Sep 2016 10:56:05 +0000 (11:56 +0100)
committerSasha Levin <alexander.levin@verizon.com>
Thu, 6 Oct 2016 02:40:20 +0000 (22:40 -0400)
commit62fc2f90511bc865c2d6386bc348283005c0f951
tree4af09786a23d644a9991db74b2425c663afdf414
parentf4e1eb5d3efa7ba4dc1c03495d5fb5dd0838762d
arm64: spinlocks: implement smp_mb__before_spinlock() as smp_mb()

[ Upstream commit 872c63fbf9e153146b07f0cece4da0d70b283eeb ]

smp_mb__before_spinlock() is intended to upgrade a spin_lock() operation
to a full barrier, such that prior stores are ordered with respect to
loads and stores occuring inside the critical section.

Unfortunately, the core code defines the barrier as smp_wmb(), which
is insufficient to provide the required ordering guarantees when used in
conjunction with our load-acquire-based spinlock implementation.

This patch overrides the arm64 definition of smp_mb__before_spinlock()
to map to a full smp_mb().

Cc: <stable@vger.kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Reported-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
arch/arm64/include/asm/spinlock.h