]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
cifs: fix integer overflow in match_server()
authorRoman Smirnov <r.smirnov@omp.ru>
Sun, 7 Sep 2025 14:58:14 +0000 (10:58 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 9 Sep 2025 16:45:25 +0000 (18:45 +0200)
commit64ddb14fd034300c3729fea5847e674ee9fb3f24
treea2d0825401f54c5ce56e23b9c293ca503e681b4c
parent071fdf70d9290425bd84e44021a450328c95cbe5
cifs: fix integer overflow in match_server()

[ Upstream commit 2510859475d7f46ed7940db0853f3342bf1b65ee ]

The echo_interval is not limited in any way during mounting,
which makes it possible to write a large number to it. This can
cause an overflow when multiplying ctx->echo_interval by HZ in
match_server().

Add constraints for echo_interval to smb3_fs_context_parse_param().

Found by Linux Verification Center (linuxtesting.org) with Svace.

Fixes: adfeb3e00e8e1 ("cifs: Make echo interval tunable")
Cc: stable@vger.kernel.org
Signed-off-by: Roman Smirnov <r.smirnov@omp.ru>
Signed-off-by: Steve French <stfrench@microsoft.com>
[ Adapted to older CIFS filesystem structure and mount option parsing ]
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/cifs/connect.c