]> git.ipfire.org Git - thirdparty/linux.git/commit
drm/nouveau: fix nvkm_device leak on aperture removal failure
authorDavid Carlier <devnexen@gmail.com>
Sat, 11 Apr 2026 06:29:38 +0000 (07:29 +0100)
committerDanilo Krummrich <dakr@kernel.org>
Wed, 15 Apr 2026 22:10:05 +0000 (00:10 +0200)
commit6597ff1d8de3f583be169587efeafd8af134e138
tree1de1f89e6c09331e0c928ff816066e376f631f9f
parentd33db956c9618e7cb08c2520ce708437914214ec
drm/nouveau: fix nvkm_device leak on aperture removal failure

When aperture_remove_conflicting_pci_devices() fails during probe, the
error path returns directly without unwinding the nvkm_device that was
just allocated by nvkm_device_pci_new(). This leaks both the device
wrapper and the pci_enable_device() reference taken inside it.

Jump to the existing fail_nvkm label so nvkm_device_del() runs and
balances both. The leak was introduced when the intermediate
nvkm_device_del() between detection and aperture removal was dropped
in favor of creating the pci device once.

Fixes: c0bfe34330b5 ("drm/nouveau: create pci device once")
Cc: stable@vger.kernel.org
Signed-off-by: David Carlier <devnexen@gmail.com>
Link: https://patch.msgid.link/20260411062938.22925-1-devnexen@gmail.com
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
drivers/gpu/drm/nouveau/nouveau_drm.c