]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
sparc64: fix incorrect sign extension in sys_sparc64_personality
authorDmitry V. Levin <ldv@altlinux.org>
Sat, 26 Dec 2015 23:13:27 +0000 (02:13 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 Mar 2016 23:06:52 +0000 (15:06 -0800)
commit670aaf542dc20fbba515a00aff228e3a03b670e7
tree083b1111176520ab7046db2d3ac50d6f46624eda
parent1dc152850f7b2c6c2ca6912c699099b1ca8f0699
sparc64: fix incorrect sign extension in sys_sparc64_personality

commit 525fd5a94e1be0776fa652df5c687697db508c91 upstream.

The value returned by sys_personality has type "long int".
It is saved to a variable of type "int", which is not a problem
yet because the type of task_struct->pesonality is "unsigned int".
The problem is the sign extension from "int" to "long int"
that happens on return from sys_sparc64_personality.

For example, a userspace call personality((unsigned) -EINVAL) will
result to any subsequent personality call, including absolutely
harmless read-only personality(0xffffffff) call, failing with
errno set to EINVAL.

Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/sparc/kernel/sys_sparc_64.c