]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ASoC: sgtl5000: Fix VAG power-on handling
authorSebastian Reichel <sebastian.reichel@collabora.com>
Tue, 14 Apr 2020 18:11:40 +0000 (20:11 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 10 May 2020 08:30:06 +0000 (10:30 +0200)
commit680b1dbec72b2bd22790d15e21bcd626caf2af7f
tree1dcb12c7a044a55c9a45ec2e56bb89567ec844fe
parent17c29ddae8d1023926662261f2e7fbb3c1d13159
ASoC: sgtl5000: Fix VAG power-on handling

[ Upstream commit aa7812737f2877e192d57626cbe8825cc7cf6de9 ]

As mentioned slightly out of patch context in the code, there
is no reset routine for the chip. On boards where the chip is
supplied by a fixed regulator, it might not even be resetted
during (e.g. watchdog) reboot and can be in any state.

If the device is probed with VAG enabled, the driver's probe
routine will generate a loud pop sound when ANA_POWER is
being programmed. Avoid this by properly disabling just the
VAG bit and waiting the required power down time.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Reviewed-by: Fabio Estevam <festivem@gmail.com>
Link: https://lore.kernel.org/r/20200414181140.145825-1-sebastian.reichel@collabora.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/codecs/sgtl5000.c
sound/soc/codecs/sgtl5000.h