]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
fbdev: of: display_timing: fix refcount leak in of_get_display_timings()
authorWeigang He <geoffreyhe2@gmail.com>
Fri, 16 Jan 2026 09:57:51 +0000 (09:57 +0000)
committerSasha Levin <sashal@kernel.org>
Wed, 4 Mar 2026 12:21:31 +0000 (07:21 -0500)
commit69290f2d3999c5fa1a7f5d5593cfc5461fa3ee64
tree876f8e3e1078da5c575a6c2fd5d585fca6b1eb61
parent40c1ff25025150ff6d7ec7ad441fcfd6d070ee76
fbdev: of: display_timing: fix refcount leak in of_get_display_timings()

[ Upstream commit eacf9840ae1285a1ef47eb0ce16d786e542bd4d7 ]

of_parse_phandle() returns a device_node with refcount incremented,
which is stored in 'entry' and then copied to 'native_mode'. When the
error paths at lines 184 or 192 jump to 'entryfail', native_mode's
refcount is not decremented, causing a refcount leak.

Fix this by changing the goto target from 'entryfail' to 'timingfail',
which properly calls of_node_put(native_mode) before cleanup.

Fixes: cc3f414cf2e4 ("video: add of helper for display timings/videomode")
Cc: stable@vger.kernel.org
Signed-off-by: Weigang He <geoffreyhe2@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/video/of_display_timing.c