]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
driver core: Fix locking bug in deferred_probe_timeout_work_func()
authorSaravana Kannan <saravanak@google.com>
Fri, 2 Apr 2021 04:03:40 +0000 (21:03 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Apr 2021 06:47:14 +0000 (08:47 +0200)
commit6a94d0febc4f96b4bfa4e7e2711ff2eff549b353
treefcd45a61f2bf5f0eb89baf93dba366cd4cbc89c5
parent72a598314b5a30c9adee1e0d563031c1fd0f79e2
driver core: Fix locking bug in deferred_probe_timeout_work_func()

commit eed6e41813deb9ee622cd9242341f21430d7789f upstream.

list_for_each_entry_safe() is only useful if we are deleting nodes in a
linked list within the loop. It doesn't protect against other threads
adding/deleting nodes to the list in parallel. We need to grab
deferred_probe_mutex when traversing the deferred_probe_pending_list.

Cc: stable@vger.kernel.org
Fixes: 25b4e70dcce9 ("driver core: allow stopping deferred probe after init")
Signed-off-by: Saravana Kannan <saravanak@google.com>
Link: https://lore.kernel.org/r/20210402040342.2944858-2-saravanak@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/dd.c