]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
platform/x86: uniwill-laptop: Fix signedness bug
authorEthan Tidmore <ethantidmore06@gmail.com>
Fri, 3 Apr 2026 07:09:28 +0000 (02:09 -0500)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Thu, 9 Apr 2026 12:01:11 +0000 (15:01 +0300)
commit6b0567dc4c9ad140044400e06dd97fdce12c204f
tree104122f468b102509fae2ce3d23bf898e57af434
parentf8fd138c2363c0e2d3235c32bfb4fb5c6474e4ae
platform/x86: uniwill-laptop: Fix signedness bug

The function sysfs_match_string() can return negative error codes and
the variable assigned to it is the enum 'option'. Which could be an
unsigned int due to different compiler implementations.

Assign signed variable 'ret' to sysfs_match_string(), check for error,
then assign ret to option.

Detected by Smatch:
drivers/platform/x86/uniwill/uniwill-acpi.c:919 usb_c_power_priority_store()
warn: unsigned 'option' is never less than zero.

Fixes: 03ae0a0d0973b ("platform/x86: uniwill-laptop: Implement USB-C power priority setting")
Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
Link: https://patch.msgid.link/20260403070928.802196-1-ethantidmore06@gmail.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/uniwill/uniwill-acpi.c