]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
arm_mpam: Check whether the config array is allocated before destroying it
authorJames Morse <james.morse@arm.com>
Fri, 8 May 2026 16:23:39 +0000 (17:23 +0100)
committerCatalin Marinas <catalin.marinas@arm.com>
Thu, 14 May 2026 08:52:05 +0000 (09:52 +0100)
commit6ccbb613b42a1f1ba7bfd547a148f644a902a25c
treeb891f723e8e4d9d8d6119f620e3241d803a6ded0
parentf1caff3335ea6eab88cdc84ec8f2e3c45ca05486
arm_mpam: Check whether the config array is allocated before destroying it

__destroy_component_cfg() is called to free the configuration array.
It uses the embedded 'garbage' structure, which means the array has
to be allocated.

If __destroy_component_cfg() is called from mpam_disable() before the
configuration was ever allocated, then a NULL pointer is dereferenced.

Check for this case and return early if the configuration is not
allocated.

__destroy_component_cfg() also frees the mbwu_state as this is allocated
by __allocate_component_cfg(). As the mbwu_state is allocated after
comp->cfg is set, and is also under mpam_list_lock, only the first
pointer needs checking.

Fixes: 3bd04fe7d807 ("arm_mpam: Extend reset logic to allow devices to be reset any time")
Cc: <stable@vger.kernel.org>
Signed-off-by: James Morse <james.morse@arm.com>
Reviewed-by: Ben Horgan <ben.horgan@arm.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
drivers/resctrl/mpam_devices.c