]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
scsi: sd: Fix return code handling in sd_spinup_disk()
authorMike Christie <michael.christie@oracle.com>
Mon, 11 May 2026 17:53:17 +0000 (12:53 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 15 May 2026 02:02:52 +0000 (22:02 -0400)
commit6ea68a8dc7d2711504d944811981a5304af7d7a9
treec27e9eab95b6f7e2c8414681d977c79da8d38504
parent98f69975d4c0434ca2e6e8cfa1d8d51647a20593
scsi: sd: Fix return code handling in sd_spinup_disk()

As found by smatch-ci, scsi_execute_cmd() can return negative or positve
values so we should use a int instead of unsigned int.

Fixes: b4d0c33a32c3 ("scsi: sd: Fix sshdr use in sd_spinup_disk")
Reported-by: Dan Carpenter <error27@gmail.com>
Closes: https://lore.kernel.org/linux-scsi/agFbI7E6JQwd3wGW@stanley.mountain/T/#u
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Link: https://patch.msgid.link/20260511175317.114007-1-michael.christie@oracle.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sd.c