]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
io_uring: fix physical SQE bounds check for SQE_MIXED 128-byte ops
authorTom Ryan <ryan36005@gmail.com>
Tue, 10 Mar 2026 05:20:02 +0000 (22:20 -0700)
committerJens Axboe <axboe@kernel.dk>
Wed, 11 Mar 2026 20:35:19 +0000 (14:35 -0600)
commit6f02c6b196036dbb6defb4647d8707d29b7fe95b
tree0758a3cd563b45231e2484e8b294dd11218396b2
parent177c69432161f6e4bab07ccacf8a1748a6898a6b
io_uring: fix physical SQE bounds check for SQE_MIXED 128-byte ops

When IORING_SETUP_SQE_MIXED is used without IORING_SETUP_NO_SQARRAY,
the boundary check for 128-byte SQE operations in io_init_req()
validated the logical SQ head position rather than the physical SQE
index.

The existing check:

  !(ctx->cached_sq_head & (ctx->sq_entries - 1))

ensures the logical position isn't at the end of the ring, which is
correct for NO_SQARRAY rings where physical == logical. However, when
sq_array is present, an unprivileged user can remap any logical
position to an arbitrary physical index via sq_array. Setting
sq_array[N] = sq_entries - 1 places a 128-byte operation at the last
physical SQE slot, causing the 128-byte memcpy in
io_uring_cmd_sqe_copy() to read 64 bytes past the end of the SQE
array.

Replace the cached_sq_head alignment check with a direct validation
of the physical SQE index, which correctly handles both sq_array and
NO_SQARRAY cases.

Fixes: 1cba30bf9fdd ("io_uring: add support for IORING_SETUP_SQE_MIXED")
Signed-off-by: Tom Ryan <ryan36005@gmail.com>
Link: https://patch.msgid.link/20260310052003.72871-1-ryan36005@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring/io_uring.c