]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
hwmon: (max6639) Fix pulses-per-revolution implementation
authorGuenter Roeck <linux@roeck-us.net>
Fri, 20 Mar 2026 04:31:22 +0000 (21:31 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 25 Mar 2026 10:13:32 +0000 (11:13 +0100)
commit6f11461f882cfde67614bc471bfdfc39474b8de5
tree89c5517885758fee472da6b8e25cb9b366401a37
parent50802d40964f327a6950562b62d1ebf7238a39fb
hwmon: (max6639) Fix pulses-per-revolution implementation

[ Upstream commit e7bae9a7a5e1251ab414291f4e9304d702bb9221 ]

The valid range for the pulses-per-revolution devicetree property is
1..4. The current code checks for a range of 1..5. Fix it.

Declare the variable used to retrieve pulses per revolution from
devicetree as u32 (unsigned) to match the of_property_read_u32() API.

The current code uses a postfix decrement when writing the pulses per
resolution into the chip. This has no effect since the value is evaluated
before it is decremented. Fix it by decrementing before evaluating the
value.

Fixes: 7506ebcd662b ("hwmon: (max6639) : Configure based on DT property")
Cc: Naresh Solanki <naresh.solanki@9elements.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hwmon/max6639.c