]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
r8169: fix potential skb double free in an error path
authorHeiner Kallweit <hkallweit1@gmail.com>
Thu, 5 Nov 2020 14:28:42 +0000 (15:28 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Nov 2020 18:20:33 +0000 (19:20 +0100)
commit6fcf4141b9a275fa4aa647974f06c1916904e3f9
treea71970e722f6f21a536e56c5e43950f457793400
parent78f6fac0814e242690d047ee5aacf093709b8797
r8169: fix potential skb double free in an error path

[ Upstream commit cc6528bc9a0c901c83b8220a2e2617f3354d6dd9 ]

The caller of rtl8169_tso_csum_v2() frees the skb if false is returned.
eth_skb_pad() internally frees the skb on error what would result in a
double free. Therefore use __skb_put_padto() directly and instruct it
to not free the skb on error.

Fixes: b423e9ae49d7 ("r8169: fix offloaded tx checksum for small packets.")
Reported-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/f7e68191-acff-9ded-4263-c016428a8762@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/realtek/r8169_main.c