]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
platform/x86: dell-wmi-sysman: Fix release_attributes_data() getting called twice...
authorHans de Goede <hdegoede@redhat.com>
Sun, 21 Mar 2021 11:58:58 +0000 (12:58 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 30 Mar 2021 12:30:25 +0000 (14:30 +0200)
commit70b139ad0836d77c5a5c07a2e20fd212490656a2
tree364794205572f160527bae3ba0039531ada91c95
parent2e6468ac29b4c79f14fb9c2a4c8dae90e223a665
platform/x86: dell-wmi-sysman: Fix release_attributes_data() getting called twice on init_bios_attributes() failure

[ Upstream commit 59bbbeb9c22cc7c55965cd5ea8c16af7f16e61eb ]

All calls of init_bios_attributes() will result in a
goto fail_create_group if they fail, which calls
release_attributes_data().

So there is no need to call release_attributes_data() from
init_bios_attributes() on failure itself.

Fixes: e8a60aa7404b ("platform/x86: Introduce support for Systems Management Driver over WMI for Dell Systems")
Cc: Divya Bharathi <Divya_Bharathi@dell.com>
Cc: Mario Limonciello <mario.limonciello@dell.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20210321115901.35072-5-hdegoede@redhat.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/platform/x86/dell-wmi-sysman/sysman.c