]> git.ipfire.org Git - thirdparty/postgresql.git/commit
xml2: Fix failure with xslt_process() under -fsanitize=undefined
authorMichael Paquier <michael@paquier.xyz>
Fri, 13 Mar 2026 07:06:51 +0000 (16:06 +0900)
committerMichael Paquier <michael@paquier.xyz>
Fri, 13 Mar 2026 07:06:51 +0000 (16:06 +0900)
commit70f7c5badcc069560993faabc744466804446246
treeb92b369dd866b09635bc31e61546ef9826b11295
parenta84a9a4260689210b87f13e7b3e13b7e8c135576
xml2: Fix failure with xslt_process() under -fsanitize=undefined

The logic of xslt_process() has never considered the fact that
xsltSaveResultToString() would return NULL for an empty string (the
upstream code has always done so, with a string length of 0).  This
would cause memcpy() to be called with a NULL pointer, something
forbidden by POSIX.

Like 46ab07ffda9d and similar fixes, this is backpatched down to all the
supported branches, with a test case to cover this scenario.  An empty
string has been always returned in xml2 in this case, based on the
history of the module, so this is an old issue.

Reported-by: Alexander Lakhin <exclusion@gmail.com>
Discussion: https://postgr.es/m/c516a0d9-4406-47e3-9087-5ca5176ebcf9@gmail.com
Backpatch-through: 14
contrib/xml2/expected/xml2.out
contrib/xml2/expected/xml2_1.out
contrib/xml2/sql/xml2.sql
contrib/xml2/xslt_proc.c