]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: bcmgenet: synchronize EXT_RGMII_OOB_CTRL access
authorDoug Berger <opendmb@gmail.com>
Wed, 15 May 2024 17:02:25 +0000 (10:02 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 May 2024 09:56:24 +0000 (11:56 +0200)
commit714e053565d4efc753a16496cd682a0a45cb8297
tree95b03e20276a609e3dc7ceec5b0c0642b46ea9bb
parented804e9d8b9a8bf2d982228779e23185b1572613
net: bcmgenet: synchronize EXT_RGMII_OOB_CTRL access

commit d85cf67a339685beae1d0aee27b7f61da95455be upstream

The EXT_RGMII_OOB_CTRL register can be written from different
contexts. It is predominantly written from the adjust_link
handler which is synchronized by the phydev->lock, but can
also be written from a different context when configuring the
mii in bcmgenet_mii_config().

The chances of contention are quite low, but it is conceivable
that adjust_link could occur during resume when WoL is enabled
so use the phydev->lock synchronizer in bcmgenet_mii_config()
to be sure.

Fixes: afe3f907d20f ("net: bcmgenet: power on MII block for all MII modes")
Cc: stable@vger.kernel.org
Signed-off-by: Doug Berger <opendmb@gmail.com>
Acked-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/broadcom/genet/bcmmii.c