]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
zram: fix use-after-free in zram_bvec_write_partial()
authorCunlong Li <shenxiaogll@gmail.com>
Thu, 28 May 2026 02:48:44 +0000 (10:48 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Wed, 3 Jun 2026 23:25:50 +0000 (16:25 -0700)
commit732fd9f0b9c1cdc6dfd77162ded60df005182cc0
tree761113fb0c52bfb79710d687a82b08f3b6782bea
parent8ad974459aef3349ec5cb3cc54e2bfc1b7aebf34
zram: fix use-after-free in zram_bvec_write_partial()

zram_read_page() picks the sync or async backing device read path based on
whether the parent bio is NULL.  zram_bvec_write_partial() passes its
parent bio down, so for ZRAM_WB slots the read is dispatched
asynchronously and zram_read_page() returns 0 while the bio is still in
flight.  The caller then runs memcpy_from_bvec(), zram_write_page() and
__free_page() on the buffer, leaving the async read to write into a freed
page.

zram_bvec_read_partial() was switched to NULL in commit 4e3c87b9421d
("zram: fix synchronous reads") for the same reason; the write_partial
counterpart was missed.

Link: https://lore.kernel.org/20260528-zram-v3-1-cab86eef8764@gmail.com
Fixes: 8e654f8fbff5 ("zram: read page from backing device")
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Signed-off-by: Cunlong Li <shenxiaogll@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Yisheng Xie <xieyisheng1@huawei.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/block/zram/zram_drv.c