]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mnt_ns_tree_remove(): DTRT if mnt_ns had never been added to mnt_ns_list
authorAl Viro <viro@zeniv.linux.org.uk>
Tue, 26 Aug 2025 20:35:55 +0000 (16:35 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 19 Oct 2025 14:37:44 +0000 (16:37 +0200)
commit7381cd12252565a83f5060ee7e9bf3aa40e9265a
tree498a93c5a6669c1cdfa243e2efcb3ed3683b17a4
parentb7b12f5e02e30f015888ce86cad88a8a62e61534
mnt_ns_tree_remove(): DTRT if mnt_ns had never been added to mnt_ns_list

[ Upstream commit 38f4885088fc5ad41b8b0a2a2cfc73d01e709e5c ]

Actual removal is done under the lock, but for checking if need to bother
the lockless RB_EMPTY_NODE() is safe - either that namespace had never
been added to mnt_ns_tree, in which case the the node will stay empty, or
whoever had allocated it has called mnt_ns_tree_add() and it has already
run to completion.  After that point RB_EMPTY_NODE() will become false and
will remain false, no matter what we do with other nodes in the tree.

Reviewed-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/namespace.c