]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
dmaengine: qcom: bam_dma: Fix resource leak
authorJeffrey Hugo <jeffrey.l.hugo@gmail.com>
Thu, 17 Oct 2019 15:26:06 +0000 (08:26 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 10 Nov 2019 10:25:37 +0000 (11:25 +0100)
commit7556e63b40f78a43553acd9f4912ceff322fad6f
tree44c81b7ab5eddb5effdaca884953a63a6331c3c1
parenta9de6f42e945cdb24b59c7ab7ebad1eba6cb5875
dmaengine: qcom: bam_dma: Fix resource leak

commit 7667819385457b4aeb5fac94f67f52ab52cc10d5 upstream.

bam_dma_terminate_all() will leak resources if any of the transactions are
committed to the hardware (present in the desc fifo), and not complete.
Since bam_dma_terminate_all() does not cause the hardware to be updated,
the hardware will still operate on any previously committed transactions.
This can cause memory corruption if the memory for the transaction has been
reassigned, and will cause a sync issue between the BAM and its client(s).

Fix this by properly updating the hardware in bam_dma_terminate_all().

Fixes: e7c0fe2a5c84 ("dmaengine: add Qualcomm BAM dma driver")
Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20191017152606.34120-1-jeffrey.l.hugo@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/dma/qcom/bam_dma.c