]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
scsi: snic: Fix possible memory leak if device_add() fails
authorZhu Wang <wangzhu9@huawei.com>
Tue, 1 Aug 2023 11:14:21 +0000 (19:14 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Aug 2023 16:27:30 +0000 (18:27 +0200)
commit7723a5d5d187626c4c640842e522cf4e9e39492e
treea2a71b575f8da4ba49511056243d7dda18386b34
parent9fdb273ede6f4428f44b09267a95f2a10b738809
scsi: snic: Fix possible memory leak if device_add() fails

commit 41320b18a0e0dfb236dba4edb9be12dba1878156 upstream.

If device_add() returns error, the name allocated by dev_set_name() needs
be freed. As the comment of device_add() says, put_device() should be used
to give up the reference in the error path. So fix this by calling
put_device(), then the name can be freed in kobject_cleanp().

Fixes: c8806b6c9e82 ("snic: driver for Cisco SCSI HBA")
Signed-off-by: Zhu Wang <wangzhu9@huawei.com>
Acked-by: Narsimhulu Musini <nmusini@cisco.com>
Link: https://lore.kernel.org/r/20230801111421.63651-1-wangzhu9@huawei.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/snic/snic_disc.c