]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
media: iris: Prevent output buffer queuing before stream-on completes
authorVishnu Reddy <busanna.reddy@oss.qualcomm.com>
Mon, 29 Dec 2025 06:31:25 +0000 (12:01 +0530)
committerSasha Levin <sashal@kernel.org>
Wed, 4 Mar 2026 12:21:10 +0000 (07:21 -0500)
commit77f69aa4deb18bab808407e5305a4571389cbf71
tree9d6758269657fac1cbbde421fc23a517c8f3adce
parent72846441c5f6396de9face04e77fa3d28e9915b6
media: iris: Prevent output buffer queuing before stream-on completes

[ Upstream commit 2c73cfd0cfc44ffe331ccb81f6ac45fc399d9ddb ]

During normal playback, stream-on for input is followed by output, and
only after input stream-on does actual streaming begin. However, when
gst-play performs a seek, both input and output streams are stopped,
and on restart, output stream-on occurs first. At this point, firmware
has not yet started streaming. Queuing output buffers before the firmware
begins streaming causes it to process buffers in an invalid state, leading
to an error response. These buffers are returned to the driver as errors,
forcing the driver into an error state and stopping playback.

Fix this by deferring output buffer queuing until stream-on completes.
Input buffers can still be queued before stream-on as required.

Fixes: 92e007ca5ab6 ("media: iris: Add V4L2 streaming support for encoder video device")
Signed-off-by: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
Signed-off-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
Reviewed-by: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
Cc: stable@vger.kernel.org
Signed-off-by: Bryan O'Donoghue <bod@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/platform/qcom/iris/iris_vb2.c