]> git.ipfire.org Git - thirdparty/linux.git/commit
spi: spi-mem: avoid mutating op template in spi_mem_supports_op()
authorSanthosh Kumar K <s-k6@ti.com>
Wed, 27 May 2026 17:37:36 +0000 (23:07 +0530)
committerMark Brown <broonie@kernel.org>
Thu, 28 May 2026 12:49:00 +0000 (13:49 +0100)
commit79378db6a86c7014cce40b65252e6c18f5b8bcc2
tree74dcdd5a8cf386a8c421031ffacbb011f8f53496
parent60474437af5fe12abd20607766c809e0ad4e7245
spi: spi-mem: avoid mutating op template in spi_mem_supports_op()

spi_mem_supports_op() accepts a const struct spi_mem_op pointer but
casts away const internally to call spi_mem_adjust_op_freq(). This
mutates the caller's op template, which causes stale max_freq values
when callers reuse persistent templates - subsequent calls won't
re-apply the device frequency cap since spi_mem_adjust_op_freq()
skips non-zero values.

Fix by operating on a stack-local copy instead.

Fixes: a4f8e70d75dd ("spi: spi-mem: add spi_mem_adjust_op_freq() in spi_mem_supports_op()")
Cc: Tianyu Xu <xtydtc@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Santhosh Kumar K <s-k6@ti.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://patch.msgid.link/20260527173736.2243004-1-s-k6@ti.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-mem.c