]> git.ipfire.org Git - thirdparty/bind9.git/commit
Remove unnecessary operations
authorMark Andrews <marka@isc.org>
Tue, 9 Jul 2024 00:29:30 +0000 (10:29 +1000)
committerMark Andrews <marka@isc.org>
Fri, 2 Aug 2024 06:42:59 +0000 (06:42 +0000)
commit7b238ba36a8bae36ac583c7380658e7d2f2ae91d
treefc47d5684bcf8bef13c0dd0307b98a97b9727314
parent6d06e7e7e585e30b419e4e20815cb8233c48f7b1
Remove unnecessary operations

Decrementing optlen immediately before calling continue is unneccesary
and inconsistent with the rest of dns_message_pseudosectiontoyaml
and dns_message_pseudosectiontotext.  Coverity was also reporting
an impossible false positive overflow of optlen (CID 499061).

    4176                        } else if (optcode == DNS_OPT_CLIENT_TAG) {
    4177                                uint16_t id;
    4178                                ADD_STRING(target, "; CLIENT-TAG:");
    4179                                if (optlen == 2U) {
    4180                                        id = isc_buffer_getuint16(&optbuf);
    4181                                        snprintf(buf, sizeof(buf), " %u\n", id);
    4182                                        ADD_STRING(target, buf);

    CID 499061: (#1 of 1): Overflowed constant (INTEGER_OVERFLOW)
    overflow_const: Expression optlen, which is equal to 65534, underflows
    the type that receives it, an unsigned integer 16 bits wide.
    4183                                        optlen -= 2;
    4184                                        POST(optlen);
    4185                                        continue;
    4186                                }
    4187                        } else if (optcode == DNS_OPT_SERVER_TAG) {

(cherry picked from commit 47338c2c876970cdd8c0e07532b88bc65bf1ea3c)
lib/dns/message.c