]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix minor bugs in commit 30bf4689a96cd283af33edcdd6b7210df3f20cd8 et al.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 30 Nov 2014 17:20:54 +0000 (12:20 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 30 Nov 2014 17:20:54 +0000 (12:20 -0500)
commit7b46ef1dad84c6d2954dcf426df5755f6968aa6a
treee2b15b5f7aec318f4d1ac301bbcf8531b7feb78d
parenta1cd04cd0dd6e025d832b1562fe8be3bbbbb2d96
Fix minor bugs in commit 30bf4689a96cd283af33edcdd6b7210df3f20cd8 et al.

Coverity complained that the "else" added to fillPGconn() was unreachable,
which it was.  Remove the dead code.  In passing, rearrange the tests so as
not to bother trying to fetch values for options that can't be assigned.

Pre-9.3 did not have that issue, but it did have a "return" that should be
"goto oom_error" to ensure that a suitable error message gets filled in.
src/interfaces/libpq/fe-connect.c