]> git.ipfire.org Git - thirdparty/bind9.git/commit
Fix CID 352776: Concurrent data access violations
authorMatthijs Mekking <matthijs@isc.org>
Mon, 16 May 2022 17:00:47 +0000 (19:00 +0200)
committerMatthijs Mekking <matthijs@isc.org>
Mon, 23 May 2022 10:03:56 +0000 (12:03 +0200)
commit7c42c04f3fa1c6b936debe48b435b9ef9da464bd
tree27b7da1f9cb858f8190c67712969a86a00776b7e
parent56adb30e2364ef6115a6af45d391a8e8382acc9b
Fix CID 352776: Concurrent data access violations

*** CID 352776:  Concurrent data access violations  (MISSING_LOCK)
/lib/dns/dst_api.c: 474 in dst_key_setmodified()
468     dst_key_isexternal(dst_key_t *key) {
469 return (key->external);
470     }
471
472     void
473     dst_key_setmodified(dst_key_t *key, bool value) {
>>>     CID 352776:  Concurrent data access violations  (MISSING_LOCK)
>>>     Accessing "key->modified" without holding lock
>>> "dst_key.mdlock". Elsewhere, "dst_key.modified" is accessed with
>>> "dst_key.mdlock" held 8 out of 11 times (8 of these accesses
>>> strongly imply that it is necessary).
474 key->modified = value;
475     }
476
477     bool
478     dst_key_ismodified(dst_key_t *key) {
479 return (key->modified);

(cherry picked from commit 1fa24d0afbc01d25d71446156758b3a945db5b5f)
lib/dns/dst_api.c
lib/dns/include/dst/dst.h