]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: ks8851-ml: Fix 16-bit IO operation
authorMarek Vasut <marex@denx.de>
Sat, 15 Feb 2020 16:54:19 +0000 (17:54 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 11 Mar 2020 06:51:16 +0000 (07:51 +0100)
commit7d6fd92a1b3c8b4fa28a2e9f272793ffcd0a5482
tree6e752d1112abbcfab298b37349b4d7c48632aada
parent77e7fcdbd0cbcdc069d6ae992f231ee1e3a6c5e5
net: ks8851-ml: Fix 16-bit IO operation

[ Upstream commit 58292104832fef6cb4a89f736012c0e0724c3442 ]

The Micrel KSZ8851-16MLLI datasheet DS00002357B page 12 states that
BE[3:0] signals are active high. This contradicts the measurements
of the behavior of the actual chip, where these signals behave as
active low. For example, to read the CIDER register, the bus must
expose 0xc0c0 during the address phase, which means BE[3:0]=4'b1100.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: David S. Miller <davem@davemloft.net>
Cc: Lukas Wunner <lukas@wunner.de>
Cc: Petr Stetiar <ynezz@true.cz>
Cc: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/micrel/ks8851_mll.c