]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
selftests/cgroup: Fix error path leaks in test_percpu_basic
authorYu Miao <yumiao@kylinos.cn>
Wed, 13 May 2026 02:39:07 +0000 (10:39 +0800)
committerTejun Heo <tj@kernel.org>
Wed, 13 May 2026 18:40:52 +0000 (08:40 -1000)
commit7d8f3158a51cb40fc710d2a781549141a139b796
treea11cee7e4edaf151928ca083230ab50ca0b3ce1e
parent5dd74441cbf42c22e874450eb6a6bbb19390a216
selftests/cgroup: Fix error path leaks in test_percpu_basic

When cg_name_indexed() returns NULL partway through the child creation
loop, the code returned -1 without running cleanup_children and cleanup.
That left the `parent` pathname allocation unreleased and did not remove
child cgroup directories already created under the parent. Fix by jumping
to cleanup_children instead of returning.

When cg_create() fails, `child` (the pathname from cg_name_indexed())
was not freed before cleanup_children. Fix by freeing `child` before
branching to cleanup_children.

Fixes: 90631e1dea55 ("kselftests: cgroup: add perpcu memory accounting test")
Signed-off-by: Yu Miao <yumiao@kylinos.cn>
Signed-off-by: Tejun Heo <tj@kernel.org>
tools/testing/selftests/cgroup/test_kmem.c