]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
thunderbolt: Fix a leak in tb_retimer_add()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 29 Mar 2021 06:07:18 +0000 (09:07 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Apr 2021 06:47:13 +0000 (08:47 +0200)
commit7fb9c6165a6f1ecb4dd1c9b042cbc61cc31f4ebd
tree811695ee0225199af7623ff098ec13eef5b4b2e2
parent1c453cfc613e02dab9df2866e9548883b338b1fd
thunderbolt: Fix a leak in tb_retimer_add()

commit bec4d7c93afc07dd0454ae41c559513f858cfb83 upstream.

After the device_register() succeeds, then the correct way to clean up
is to call device_unregister().  The unregister calls both device_del()
and device_put().  Since this code was only device_del() it results in
a memory leak.

Fixes: dacb12877d92 ("thunderbolt: Add support for on-board retimers")
Cc: stable@vger.kernel.org
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/thunderbolt/retimer.c