]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ALSA: ump: Set default protocol when not given explicitly
authorTakashi Iwai <tiwai@suse.de>
Wed, 29 May 2024 16:47:17 +0000 (18:47 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 11 Jul 2024 10:51:23 +0000 (12:51 +0200)
commit7fd41a2b790ddd87aa26f74f4896671a382437d5
treef4496f0ac7c32c1da701065ccccc3cecb66acb40
parentae5db98a264809819dc3c8ee2ab3271a8b872dfd
ALSA: ump: Set default protocol when not given explicitly

[ Upstream commit bc42ca002d5d211f9c57334b9b4c25ddb0b4ec35 ]

When an inquiry of the current protocol via UMP Stream Configuration
message fails by some reason, we may leave the current protocol
undefined, which may lead to unexpected behavior.  Better to assume a
valid protocol found in the protocol capability bits instead.

For a device that doesn't support the UMP v1.2 feature, it won't reach
to this code path, and USB MIDI GTB descriptor would be used for
determining the protocol, instead.

Link: https://lore.kernel.org/r/20240529164723.18309-2-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/core/ump.c