]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tg3: Fix race condition in tg3_get_stats64().
authorMichael Chan <michael.chan@broadcom.com>
Fri, 6 Jan 2017 21:18:53 +0000 (16:18 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 11 Aug 2017 16:30:15 +0000 (09:30 -0700)
commit80334372c59660b41e7526070fef5261fad4c28c
tree2589e745586f68bdb36f82947d01926a20e7b230
parent032067e2588b7c15ac0fe084fd498b238cb18e76
tg3: Fix race condition in tg3_get_stats64().

[ Upstream commit f5992b72ebe0dde488fa8f706b887194020c66fc ]

The driver's ndo_get_stats64() method is not always called under RTNL.
So it can race with driver close or ethtool reconfigurations.  Fix the
race condition by taking tp->lock spinlock in tg3_free_consistent()
when freeing the tp->hw_stats memory block.  tg3_get_stats64() is
already taking tp->lock.

Reported-by: Wang Yufen <wangyufen@huawei.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/broadcom/tg3.c