]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
vt: keyboard: Use led_set_brightness() in LED trigger activate() callback
authorHans de Goede <hdegoede@redhat.com>
Sat, 11 May 2024 15:20:30 +0000 (17:20 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 4 Jun 2024 12:00:53 +0000 (14:00 +0200)
commit80c4d3d4890563632d7bcc8d048dbd4e1c519f17
treef8dfb2e5665238399fbe79e5de643c887f1362d3
parent0bb17fdc6735517c2127ba058126dd104cb3ee30
vt: keyboard: Use led_set_brightness() in LED trigger activate() callback

A LED trigger's activate() callback gets called when the LED trigger
gets activated for a specific LED, so that the trigger code can ensure
the LED state matches the current state of the trigger condition.

led_trigger_event() is intended for trigger condition state changes and
iterates over _all_ LEDs which are controlled by this trigger changing
the brightness of each of them.

In the activate() case only the brightness of the LED which is being
activated needs to change and that LED is passed as an argument to
activate(), switch to led_set_brightness() to only change the brightness
of the LED being activated.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20240511152030.4848-1-hdegoede@redhat.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/vt/keyboard.c