]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
rust: regulator: do not assume that regulator_get() returns non-null
authorAlice Ryhl <aliceryhl@google.com>
Tue, 24 Mar 2026 10:49:59 +0000 (10:49 +0000)
committerMark Brown <broonie@kernel.org>
Tue, 24 Mar 2026 13:08:21 +0000 (13:08 +0000)
commit8121353a4bf8e38afee26299419a78ec108e14a6
tree9d74b61dcc606c0b36718ddae93cd641ea81ef7f
parentc369299895a591d96745d6492d4888259b004a9e
rust: regulator: do not assume that regulator_get() returns non-null

The Rust `Regulator` abstraction uses `NonNull` to wrap the underlying
`struct regulator` pointer. When `CONFIG_REGULATOR` is disabled, the C
stub for `regulator_get` returns `NULL`. `from_err_ptr` does not treat
`NULL` as an error, so it was passed to `NonNull::new_unchecked`,
causing undefined behavior.

Fix this by using a raw pointer `*mut bindings::regulator` instead of
`NonNull`. This allows `inner` to be `NULL` when `CONFIG_REGULATOR` is
disabled, and leverages the C stubs which are designed to handle `NULL`
or are no-ops.

Fixes: 9b614ceada7c ("rust: regulator: add a bare minimum regulator abstraction")
Reported-by: Miguel Ojeda <ojeda@kernel.org>
Closes: https://lore.kernel.org/r/20260322193830.89324-1-ojeda@kernel.org
Signed-off-by: Alice Ryhl <aliceryhl@google.com>
Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>
Link: https://patch.msgid.link/20260324-regulator-fix-v1-1-a5244afa3c15@google.com
Signed-off-by: Mark Brown <broonie@kernel.org>
rust/kernel/regulator.rs