]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ftruncate: pass a signed offset
authorArnd Bergmann <arnd@arndb.de>
Wed, 19 Jun 2024 09:34:09 +0000 (11:34 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 5 Jul 2024 07:34:04 +0000 (09:34 +0200)
commit836359247b0403e0634bfbc83e5bb8063fad287a
treee52c92f5c7c400fd173496349ad38f453dcd1e93
parent062e256516d7db5e7dcdef117f52025cd5c456e3
ftruncate: pass a signed offset

commit 4b8e88e563b5f666446d002ad0dc1e6e8e7102b0 upstream.

The old ftruncate() syscall, using the 32-bit off_t misses a sign
extension when called in compat mode on 64-bit architectures.  As a
result, passing a negative length accidentally succeeds in truncating
to file size between 2GiB and 4GiB.

Changing the type of the compat syscall to the signed compat_off_t
changes the behavior so it instead returns -EINVAL.

The native entry point, the truncate() syscall and the corresponding
loff_t based variants are all correct already and do not suffer
from this mistake.

Fixes: 3f6d078d4acc ("fix compat truncate/ftruncate")
Reviewed-by: Christian Brauner <brauner@kernel.org>
Cc: stable@vger.kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/open.c
include/linux/compat.h
include/linux/syscalls.h