]> git.ipfire.org Git - thirdparty/libvirt.git/commit
meson: fix readline detection if there is no pkg-config file
authorPavel Hrdina <phrdina@redhat.com>
Wed, 5 Aug 2020 10:39:24 +0000 (12:39 +0200)
committerPavel Hrdina <phrdina@redhat.com>
Wed, 5 Aug 2020 11:32:59 +0000 (13:32 +0200)
commit84bb5fd1ab2bce88e508d416f4bcea520c803ea8
tree98e8bdcb9b64dac6a2f4f1f528aee6118a90350d
parentf1a298c20d3d210427896dfd4c5f78db1a725074
meson: fix readline detection if there is no pkg-config file

Commit <74416b1d4849ef77ef31de5344dd75f03094434b> added check for
rl_completion_quote_character to make sure we have correct readline
library. Commit <a9443bc9a9ef451b46306e66ed3b706756fc1414> added
inaccurate comment that it's a function.

We need to check for generic symbol instead of checking for function.
In addition the readline/readline.h file requires stdio.h to by included
beforehand which was done in autotools but I dropped it in meson.

And lastly the final condition to print error or disable readline was
broken as well by replacing the readline_dep every time if readline was
not explicitly enabled.

Reported-by: Erik Skultety <eskultet@redhat.com>
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
meson.build