]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
iio: potentiometer: mcp4131: fix double application of wiper shift
authorLukas Schmid <lukas.schmid@netcube.li>
Mon, 2 Feb 2026 20:15:35 +0000 (21:15 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 23 Feb 2026 08:24:37 +0000 (08:24 +0000)
commit85e4614524dca6c0a43874f475a17de2b9725648
treef255aaeb103f9ed75f9d21445aad1ff6cc0ab464
parentd23d763e00ace4e9c59f8d33e0713d401133ba88
iio: potentiometer: mcp4131: fix double application of wiper shift

The MCP4131 wiper address is shifted twice when preparing the SPI
command in mcp4131_write_raw().

The address is already shifted when assigned to the local variable
"address", but is then shifted again when written to data->buf[0].
This results in an incorrect command being sent to the device and
breaks wiper writes to the second channel.

Remove the second shift and use the pre-shifted address directly
when composing the SPI transfer.

Fixes: 22d199a53910 ("iio: potentiometer: add driver for Microchip MCP413X/414X/415X/416X/423X/424X/425X/426X")
Signed-off-by: Lukas Schmid <lukas.schmid@netcube.li>#
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/potentiometer/mcp4131.c