]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commit
Add typing overloads to Query.__getitem__ and AppenderQuery.__getitem__
authormedovi40k <danyafghtv@gmail.com>
Sat, 28 Feb 2026 23:10:17 +0000 (18:10 -0500)
committerFederico Caselli <cfederico87@gmail.com>
Wed, 18 Mar 2026 22:31:41 +0000 (23:31 +0100)
commit86ac0a7be3c67c284d8df7813bc4967c4ff76bc7
tree403bdf0cf23fd2831c50fbe9c291afe535e725b0
parent6d0f61fd171dc34827cd402f5e18cdd15ec0683e
Add typing overloads to Query.__getitem__ and AppenderQuery.__getitem__

Fixes #13128

### Description
`Query.__getitem__` and `AppenderQuery.__getitem__` previously returned Union[_T, List[_T]] for all inputs, making the return type inaccurate.
Added `@overload` signatures so that integer index returns _T and slice returns List[_T].

This pull request is:

- [x] A documentation / typographical / small typing error fix
- Good to go, no issue or tests are needed

Closes: #13142
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/13142
Pull-request-sha: 9ba1f0145d90b18c997137aeba7fde72dac23a7c

Change-Id: Ib37ab63d3d844491c34cc5ccfc4efc1591a1878c
(cherry picked from commit 8af25c2b35f3740a00e2551c65f9ba245e6f5a9d)
lib/sqlalchemy/orm/dynamic.py
lib/sqlalchemy/orm/query.py
test/typing/plain_files/orm/dynamic_rel.py
test/typing/plain_files/orm/typed_queries.py