]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Detect Julian-date overflow in timestamp[tz]_pl_interval.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 26 Jan 2024 18:39:37 +0000 (13:39 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 26 Jan 2024 18:39:37 +0000 (13:39 -0500)
commit86b6243a8ea92760679b6d9a8bbaab562b27a9db
tree6ffafa6106cf9ff601cac1faefd2d0d29c461fee
parent67f7aaa38172155ab2d8a2248e87b5d0b7dc6444
Detect Julian-date overflow in timestamp[tz]_pl_interval.

We perform addition of the days field of an interval via
arithmetic on the Julian-date representation of the timestamp's date.
This step is subject to int32 overflow, and we also should not let
the Julian date become very negative, for fear of weird results from
j2date.  (In the timestamptz case, allow a Julian date of -1 to pass,
since it might convert back to zero after timezone rotation.)

The additions of the months and microseconds fields could also
overflow, of course.  However, I believe we need no additional
checks there; the existing range checks should catch such cases.
The difficulty here is that j2date's magic modular arithmetic could
produce something that looks like it's in-range.

Per bug #18313 from Christian Maurer.  This has been wrong for
a long time, so back-patch to all supported branches.

Discussion: https://postgr.es/m/18313-64d2c8952d81e84b@postgresql.org
src/backend/utils/adt/timestamp.c
src/test/regress/expected/horology.out
src/test/regress/sql/horology.sql