]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Move check for fsync=off so that pendingOps still gets cleared.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 14 May 2020 05:39:26 +0000 (08:39 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 14 May 2020 05:40:19 +0000 (08:40 +0300)
commit891a2007e3987545a2543c1f04cd0682576b39fa
tree5fb36a11811dfd0a42508fda589422771b42ba13
parent98171e59a6cae02b5efdbf6de12bc630d58373c6
Move check for fsync=off so that pendingOps still gets cleared.

Commit 3eb77eba5a moved the loop and refactored it, and inadvertently
changed the effect of fsync=off so that it also skipped removing entries
from the pendingOps table. That was not intentional, and leads to an
assertion failure if you turn fsync on while the server is running and
reload the config.

Backpatch-through: 12-
Reviewed-By: Thomas Munro
Discussion: https://www.postgresql.org/message-id/3cbc7f4b-a5fa-56e9-9591-c886deb07513%40iki.fi
src/backend/storage/sync/sync.c