]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
cifs: fix incorrect check for null pointer in header_assemble
authorSteve French <stfrench@microsoft.com>
Fri, 24 Sep 2021 00:18:37 +0000 (19:18 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Sep 2021 08:09:21 +0000 (10:09 +0200)
commit8b06b0f17f359f9dd99ad4af1282e90b0d4bdff3
tree2a323f2bd1798987bef8eae50faff04c08602a31
parentb1f6efa27b242fa80b842be6568b5e2c7ee4a43a
cifs: fix incorrect check for null pointer in header_assemble

commit 9ed38fd4a15417cac83967360cf20b853bfab9b6 upstream.

Although very unlikely that the tlink pointer would be null in this case,
get_next_mid function can in theory return null (but not an error)
so need to check for null (not for IS_ERR, which can not be returned
here).

Address warning:

        fs/smbfs_client/connect.c:2392 cifs_match_super()
        warn: 'tlink' isn't an ERR_PTR

Pointed out by Dan Carpenter via smatch code analysis tool

CC: stable@vger.kernel.org
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/cifs/connect.c