]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
bpo-40791: Make compare_digest more constant-time. (GH-23438) (GH-23767)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Mon, 14 Dec 2020 17:04:57 +0000 (09:04 -0800)
committerGitHub <noreply@github.com>
Mon, 14 Dec 2020 17:04:57 +0000 (12:04 -0500)
commit8bef9ebb1b88cfa4b2a38b93fe4ea22015d8254a
tree83c849580c4e39cd05110f1efb2dab7ac79c0579
parentdae5d728bc3f1d4039b64e4ec3a9036fd5d19587
bpo-40791: Make compare_digest more constant-time. (GH-23438) (GH-23767)

The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization.

(This is change GH-1 from https://bugs.python.org/issue40791 .)
(cherry picked from commit 31729366e2bc09632e78f3896dbce0ae64914f28)

Co-authored-by: Devin Jeanpierre <jeanpierreda@google.com>
Misc/NEWS.d/next/Security/2020-05-28-06-06-47.bpo-40791.QGZClX.rst [new file with mode: 0644]
Modules/_operator.c