]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
media: mtk-vcodec: venc: avoid -Wenum-compare-conditional warning
authorArnd Bergmann <arnd@arndb.de>
Mon, 8 Sep 2025 21:43:58 +0000 (17:43 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Oct 2025 11:35:35 +0000 (13:35 +0200)
commit8c6b68871a9d7b78983b8af94097d0827022b51a
tree77f557a0d037070df970f2da8c3df74729c6f534
parent658720b7f3982d096f6045c8f1a39cfe9faaaec1
media: mtk-vcodec: venc: avoid -Wenum-compare-conditional warning

[ Upstream commit 07df4f23ef3ffe6fee697cd2e03623ad27108843 ]

This is one of three clang warnings about incompatible enum types
in a conditional expression:

drivers/media/platform/mediatek/vcodec/encoder/venc/venc_h264_if.c:597:29: error: conditional expression between different enumeration types ('enum scp_ipi_id' and 'enum ipi_id') [-Werror,-Wenum-compare-conditional]
  597 |         inst->vpu_inst.id = is_ext ? SCP_IPI_VENC_H264 : IPI_VENC_H264;
      |                                    ^ ~~~~~~~~~~~~~~~~~   ~~~~~~~~~~~~~

The code is correct, so just rework it to avoid the warning.

Fixes: 0dc4b3286125 ("media: mtk-vcodec: venc: support SCP firmware")
Cc: stable@vger.kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Alexandre Courbot <acourbot@google.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
[ Adapted file path ]
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c